fix: Auth page when user login #107
Merged
+464
−420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rayokamoto
requested changes
Feb 24, 2024
| NEXT_PUBLIC_CLERK_SIGN_IN_URL=/signin | ||
| NEXT_PUBLIC_CLERK_SIGN_UP_URL=/join | ||
| NEXT_PUBLIC_CLERK_AFTER_SIGN_IN_URL=/ | ||
| NEXT_PUBLIC_CLERK_AFTER_SIGN_UP_URL=/ |
There was a problem hiding this comment.
Do we want this to be the home page or should it be /settings in the membership tab so that people have direct access to pay?
There was a problem hiding this comment.
aftersignin here is not the main logic. if you want this, we have to do it code
There was a problem hiding this comment.
this is for, like google login, redirect url
rayokamoto
requested changes
Feb 25, 2024
src/middleware.ts
Outdated
| publicRoutes: (req) => { | ||
| return !authRoutes.includes(req.nextUrl.pathname); | ||
| }, | ||
| publicRoutes: [ |
There was a problem hiding this comment.
can you also add /not-found?
src/env.mjs
Outdated
| @@ -15,10 +15,19 @@ export const env = createEnv({ | |||
| client: { | |||
| NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: z.string().min(1), | |||
| NEXT_PUBLIC_DRIVE_LINK: z.string().url().min(1), | |||
| // Clerk URLs. Redundant, but there is no other way from Clerk. | |||
There was a problem hiding this comment.
I might reword this a bit but the general idea is there.
rayokamoto
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add logic to verify user when visit auth page
Changes Made
Related Issues
N/A
Additional Notes
N/A